T6910: fix documentation and argspecs are out of alignment #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omnom62
approved these changes
Nov 17, 2024
gaige
force-pushed
the
update-resources
branch
2 times, most recently
from
d39a618
to
126a5e2
Compare
fix: update firewall_global from resource model chore: update to sync with resource module chore: update README fix: comment and formatting fix: formatting issues fix: missing imports fix: import and metadata violations fix: interface fixes fix: move the arg spec comment fix: update interface docs fix: remove comments for non-RM versions
gaige
force-pushed
the
update-resources
branch
7 times, most recently
from
123108c
to
495aa76
Compare
gaige
commented
Nov 23, 2024
gaige
commented
Nov 23, 2024
gaige
force-pushed
the
update-resources
branch
5 times, most recently
from
5e3563a
to
d43ad5f
Compare
gaige
changed the title
gaige
force-pushed
the
update-resources
branch
from
d43ad5f
to
0c39d65
Compare
omnom62
approved these changes
Nov 24, 2024
plugins/module_utils/network/vyos/argspec/bgp_address_family/bgp_address_family.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Minor modifications by bringing the
resource_module_builder-based modules back into line with what is generated, fixing some variances in documentation and inconsistencies in some of the modules and the documentation andtest sources.
Further, verified and regenerated argspecs based for the newer cli modules.
Types of changes
Related Task(s)
T6910: documentation and argspecs are out of alignment
Related PR(s)
Proposed changes
Updates to the resource module repo (separate) to bring them into line with the current code.
Added a custom version of the resource_builder in order to ensure we don't remove any
updates for our modules.
Regenerated until we matched all salient updates.
How to test
Unit tests and sanity tests pass; integration tests are failing in the same ways that the current mainline branch are
failing against 1.4 and 1.5 (but work against 1.3).
Checklist: