Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change firewall recent.time to string as per VyOS 1.4 #313

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

change firewall recent.time to string as per VyOS 1.4 #313

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5e8f09b
change firewall recent.count to string
athiedeilluminate Apr 11, 2023
c97082e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 11, 2023
2028984
Update plugins/module_utils/network/vyos/argspec/firewall_rules/firew…
athiedeilluminate Apr 12, 2023
b281ad8
Update plugins/modules/vyos_firewall_rules.py
athiedeilluminate Apr 12, 2023
7cde8ea
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 12, 2023
0c02834
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 12, 2023
953042b
change type to str and add changelog fragment
athiedeilluminate Apr 12, 2023
0e184c0
rename changelog fragment
athiedeilluminate Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/vyos.vyos.vyos_firewall_rules_module.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,13 +813,13 @@ Parameters
<b>time</b>
<a class="ansibleOptionLink" href="#parameter-" title="Permalink to this option"></a>
<div style="font-size: small">
<span style="color: purple">integer</span>
<span style="color: purple">text ("second", "minute", or "hour")</span>
</div>
</td>
<td>
</td>
<td>
<div>Source addresses seen in the last N seconds.</div>
<div>Source addresses seen in the last second/minute/hour.</div>
</td>
</tr>

Expand Down
9 changes: 8 additions & 1 deletion plugins/module_utils/network/vyos/argspec/firewall_rules/firewall_rules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,14 @@ def __init__(self, **kwargs):
"recent": {
"options": {
"count": {"type": "int"},
"time": {"type": "int"},
"time": {
"type": {
"choices": [
"second",
"minute",
"hour"
]
athiedeilluminate marked this conversation as resolved.
Show resolved Hide resolved
},
},
"type": "dict",
},
Expand Down
4 changes: 2 additions & 2 deletions plugins/modules/vyos_firewall_rules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,8 +293,8 @@
type: int
time:
description:
- Source addresses seen in the last N seconds.
type: int
- Source addresses seen in the last second/minute/hour.
type: text ("second", "minute", or "hour")
athiedeilluminate marked this conversation as resolved.
Show resolved Hide resolved
source:
description:
- Source parameters.
Expand Down