automation: add Golang Vyos API Client #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmbaturin
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Thanks for the effort!
I left one small suggestion. There's the legacy REST API, which the original Python client uses, and that your code uses as well. For interacting with older versions, that's essential, of course.
There's also newer GraphQL API and a plan to introduce a NETCONF-based API, so client documentation should mention which of the APIs they use.
Co-authored-by: Daniil Baturin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Wanting to share with the community, a Golang API client for Vyos I created. It has feature parity with the existing Python client.
On pkg.go.dev - https://pkg.go.dev/github.com/ganawaj/[email protected]/vyos
Source - https://github.com/ganawaj/go-vyos
Related Task(s)
Related PR(s)
Backport
Checklist: