Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image-tools: T6864: keep file necessary for compat add image #836

Merged
merged 1 commit into from
Nov 14, 2024
Merged

image-tools: T6864: keep file necessary for compat add image #836

merged 1 commit into from
Nov 14, 2024

Conversation

jestabro
Copy link
Contributor

Change Summary

This reverts commit d50707b to keep the file grub/default-union-grub-entry, necessary for compatibility-mode upgrades of the system image: when upgrading from a system with legacy image-tools, this file is expected to exist in the mounted image of the target iso.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro
image-tools: T6864: keep file necessary for compat add image
2416f96 
Revert "T1416: remove deprecated default-union-grub-entry"
This reverts commit d50707b.
The file grub/default-union-grub-entry and its companion
install-image/postinst are needed for 'compatibility-mode' upgrades:
when upgrading from a system with legacy image-tools, those two files
are expected to exist in the mounted image of the target iso.
@jestabro jestabro self-assigned this Nov 13, 2024
@jestabro jestabro requested a review from a team as a code owner November 13, 2024 21:16
@github-actions GitHub Actions
Copy link

👍
No issues in PR Title / Commit Title

@jestabro jestabro mentioned this pull request Nov 13, 2024
Merged
11 tasks
@dmbaturin dmbaturin merged commit b455954 into vyos:current Nov 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@dmbaturin dmbaturin dmbaturin approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@c-po c-po Awaiting requested review from c-po c-po is a code owner automatically assigned from vyos/reviewers

@nicolas-fort nicolas-fort Awaiting requested review from nicolas-fort nicolas-fort is a code owner automatically assigned from vyos/reviewers

Assignees

@jestabro jestabro

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jestabro @dmbaturin @sever-sever