Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T861: Fix kernel suffix for package build by actions #776

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

sever-sever
Copy link
Member

@sever-sever sever-sever commented Oct 1, 2024

Change Summary

Fix kernel suffix for package build by actions (without Jenkins)
The bug was introduced in d235b31

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

linux-kernel

Proposed changes

How to test

package

Before the fix -6.6.52-_6.6.52-1:

vyos_bld@41a0a31c2db3:/vyos/work/tmp/vyos-build/scripts/package-build/linux-kernel$ 
ls -la | grep deb
-rw-r--r--  1 vyos_bld vyos_bld   8975124 Oct  1 12:22 linux-headers-6.6.52-_6.6.52-1_amd64.deb
-rw-r--r--  1 vyos_bld vyos_bld  29464376 Oct  1 12:22 linux-image-6.6.52-_6.6.52-1_amd64.deb
-rw-r--r--  1 vyos_bld vyos_bld   1318772 Oct  1 12:22 linux-libc-dev_6.6.52-1_amd64.deb

After the fix we have correct name -6.6.52-vyos_6.6.52-1:

vyos_bld@41a0a31c2db3:/vyos/work/tmp/vyos-build/scripts/package-build/linux-kernel$ ls -la | grep .deb
-rw-r--r--  1 vyos_bld vyos_bld   8975048 Oct  1 12:42 linux-headers-6.6.52-vyos_6.6.52-1_amd64.deb
-rw-r--r--  1 vyos_bld vyos_bld  29455308 Oct  1 12:42 linux-image-6.6.52-vyos_6.6.52-1_amd64.deb
-rw-r--r--  1 vyos_bld vyos_bld   1318844 Oct  1 12:42 linux-libc-dev_6.6.52-1_amd64.deb
vyos_bld@41a0a31c2db3:/vyos/work/tmp/vyos-build/scripts/package-build/linux-kernel$ 

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Oct 1, 2024

👍
No issues in PR Title / Commit Title

@sever-sever sever-sever marked this pull request as draft October 1, 2024 13:59
@sever-sever sever-sever marked this pull request as ready for review October 1, 2024 14:05
@c-po c-po enabled auto-merge October 1, 2024 14:12
@c-po c-po merged commit 7670c25 into vyos:current Oct 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants