ethtool: T6729: upgrade to 6.10 to make use of more --json options (backport #769) #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Same as T6078 but we now wan't to make use of ethtool --json eth0 to drop out own text based parsing of ethtool options in [1]. This is the base for moving to a better, machine readable interface 1: https://github.com/vyos/vyos-1x/blob/e47d4fd385631236da68/python/vyos/ethtool.py#L77-L105 (cherry picked from commit 9e7dd13)
mergify
bot
requested review from
dmbaturin,
sarthurdev,
zdc,
jestabro,
sever-sever and
fett0
11 tasks
|
👍 |
c-po
approved these changes
Sep 21, 2024
sever-sever
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Same as T6078 but we now wan't to make use of ethtool --json eth0 to drop out own text based parsing of ethtool options in [1]. This is the base for moving to a better, machine readable interface
1: https://github.com/vyos/vyos-1x/blob/e47d4fd385631236da68/python/vyos/ethtool.py#L77-L105
Types of changes
Related Task(s)
Component(s) name
ethtool
Proposed changes
How to test
Checklist:
This is an automatic backport of pull request #769 done by [Mergify](https://mergify.com).