Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6713: Update Realtek r8152 driver #762

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

sever-sever
Copy link
Member

@sever-sever sever-sever commented Sep 13, 2024

Change Summary

Update Realted r8152 driver as the current driver works with issues

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Proposed changes

How to test

$ ./build-driver-realtek-r8152.py

$ ls -la | grep real | grep deb
-rw-r--r--  1 vyos_bld vyos_bld    112232 Sep 13 10:44 vyos-drivers-realtek-r8152_2.18.1-1_amd64.deb

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Sep 13, 2024

👍
No issues in PR Title / Commit Title

@c-po
Copy link
Member

c-po commented Sep 14, 2024

Where is the package included into the image?

Should be added here, too https://github.com/vyos/vyos-build/blob/current/data/architectures/amd64.toml#L8

@sever-sever sever-sever marked this pull request as ready for review October 1, 2024 07:40
@sever-sever
Copy link
Member Author

sever-sever commented Oct 1, 2024

Where is the package included into the image?

Should be added here, too https://github.com/vyos/vyos-build/blob/current/data/architectures/amd64.toml#L8

Added

  "vyos-drivers-realtek-r8152",

Is it correct format for the package vyos-drivers-realtek-r8152_2.18.1-1_amd64.deb?

@sever-sever sever-sever force-pushed the T6713-current-realtek branch 2 times, most recently from de9d7bb to 2ccece5 Compare October 1, 2024 10:24
@sever-sever sever-sever marked this pull request as draft October 1, 2024 13:42
@sever-sever sever-sever marked this pull request as ready for review October 2, 2024 11:49
@dmbaturin dmbaturin merged commit 49d41fa into vyos:current Oct 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants