build-script: T3664: Allowed all options in both config file and comm… (backport #622) #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…and args Moved defaults away from argparser to `defaults.py`. This unlocks the ability to pass values that can be defined as command line arguments via a config file. With this change logic looks like this (in order of overrides). Pre-build config: `data/defaults.toml` -> `build-flavors/<flavor>.toml` -> `--<command line argument>` Build config: `defaults.py` -> `data/defaults.toml` -> `build-types/<type>.toml` -> `architectures/<architecture>.toml` -> `build-flavors/<flavor>.toml` -> `--<command line argument>` (cherry picked from commit 8186e82)
11 tasks
zdc
requested review from
zdc,
a team,
dmbaturin,
sarthurdev,
jestabro,
sever-sever and
c-po
and removed request for
a team
zdc
approved these changes
May 17, 2024
sever-sever
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Allowed all options in both config file and command args
Types of changes
Related Task(s)
Component(s) name
build-script
Proposed changes
Moved defaults away from argparser to
defaults.py. This unlocks the ability to pass values that can be defined as command line arguments via a config file.With this change logic looks like this (in order of overrides).
Pre-build config:
data/defaults.toml->build-flavors/<flavor>.toml->--<command line argument>Build config:
defaults.py->data/defaults.toml->build-types/<type>.toml->architectures/<architecture>.toml->build-flavors/<flavor>.toml->--<command line argument>How to test
Checklist:
This is an automatic backport of pull request #622 done by [Mergify](https://mergify.com).