Skip to content

vyos.ifconfig: T7919: call "ip addr flush" only if interface exists #4784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: current
Choose a base branch
from
Open

vyos.ifconfig: T7919: call "ip addr flush" only if interface exists #4784

wants to merge 1 commit into from
+3 −0

Conversation

c-po
Copy link
Member

@c-po c-po commented Oct 9, 2025 •
edited
Loading

Change summary

Flushing all interface addresses on an interface that does not exists will throw a Python PermissionError. Add safe-guard to only flush interfaces still available.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po
vyos.ifconfig: T7919: call "ip addr flush" only if interface exists
3089987 
Flushing all interface addresses on an interface that does not exists
will throw a Python PermissionError. Add safe-guard to only flush interfaces
still available.
@c-po c-po added bp/sagitta Create automatic backport for sagitta LTS version bp/circinus Create automatic backport for circinus labels Oct 9, 2025
@c-po c-po self-assigned this Oct 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2025 •
edited
Loading

👍
No issues in PR Title / Commit Title

@c-po c-po added bp/sagitta Create automatic backport for sagitta LTS version bp/circinus Create automatic backport for circinus labels Oct 9, 2025
jestabro
jestabro approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@jestabro jestabro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a reasonable safe-guard.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2025

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests VPP ❌ failed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • Config tests VPP 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jestabro jestabro jestabro approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev

@sever-sever sever-sever Awaiting requested review from sever-sever

At least 2 approving reviews are required to merge this pull request.

Assignees

@c-po c-po

Labels
bp/circinus Create automatic backport for circinus bp/sagitta Create automatic backport for sagitta LTS version current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-po @jestabro