-
Notifications
You must be signed in to change notification settings - Fork 390
T7789: T7661: VPP prevent failing to load XDP in clouds (ena/gve drivers) #4747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: current
Are you sure you want to change the base?
Conversation
👍 |
8e406f9
to
b27a553
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ethtool --show-channel
, unfortunately, doesn't support --json
, so the output parsing is necessary.
The rest of the logic also seems fine to me.
b27a553
to
0a8556d
Compare
0a8556d
to
4187628
Compare
CI integration ❌ failed! Details
|
if rx_queues > max_rx_queues: | ||
raise ConfigError( | ||
f'Maximum supported number of RX queues for interface {iface} is {max_rx_queues}. ' | ||
f'Please set "xdp-options num-rx-queues" to {max_rx_queues} or fewer' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It allows to set all
, but doesn't allow to set 7 after this
vyos@r14# sudo ethtool -l eth1
Channel parameters for eth1:
Pre-set maximums:
RX: n/a
TX: n/a
Other: n/a
Combined: 8
Current hardware settings:
RX: n/a
TX: n/a
Other: n/a
Combined: 4
[edit]
vyos@r14#
[edit]
vyos@r14# set vpp settings interface eth1 driver xdp
[edit]
vyos@r14# set vpp settings interface eth1 xdp-options num-rx-queues all
[edit]
vyos@r14# commit
[edit]
vyos@r14#
[edit]
vyos@r14# set vpp settings interface eth1 xdp-options num-rx-queues 8
[edit]
vyos@r14# commit
[ vpp ]
Maximum supported number of RX queues for interface eth1 is 4. Please
set "xdp-options num-rx-queues" to 4 or fewer
[[vpp]] failed
Commit failed
[edit]
vyos@r14# sudo ethtool -l defunct_eth1
Channel parameters for defunct_eth1:
Pre-set maximums:
RX: n/a
TX: n/a
Other: n/a
Combined: 8
Current hardware settings:
RX: n/a
TX: n/a
Other: n/a
Combined: 8
[edit]
vyos@r14#
vyos@r14# set vpp settings interface eth1 xdp-options num-rx-queues 7
[edit]
vyos@r14# commit
[ vpp ]
Maximum supported number of RX queues for interface eth1 is 4. Please
set "xdp-options num-rx-queues" to 4 or fewer
[[vpp]] failed
Commit failed
[edit]
vyos@r14#
If we try to set 2, afoter those steps:
vyos@r14# set vpp settings interface eth1 xdp-options num-rx-queues 2
[edit]
vyos@r14# commit
[ vpp ]
WARNING: Not all RX queues will be connected to VPP for eth1!
[edit]
vyos@r14# sudo ethtool -l defunct_eth1
Channel parameters for defunct_eth1:
Pre-set maximums:
RX: n/a
TX: n/a
Other: n/a
Combined: 8
Current hardware settings:
RX: n/a
TX: n/a
Other: n/a
Combined: 8
[edit]
vyos@r14#
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Change summary
Types of changes
Related Task(s)
Related PR(s)
How to test / Smoketest result
Checklist: