Skip to content

Conversation

natali-rs1985
Copy link
Contributor

Change summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Sep 24, 2025

👍
No issues in PR Title / Commit Title

@natali-rs1985 natali-rs1985 force-pushed the T7789 branch 3 times, most recently from 8e406f9 to b27a553 Compare September 24, 2025 14:40
@natali-rs1985 natali-rs1985 added the bp/circinus Create automatic backport for circinus label Sep 24, 2025
@dmbaturin dmbaturin changed the title T7789: T7661: VPP prevent failing to set XDP driver on clouds T7789: T7661: VPP prevent failing to set XDP driver in clouds Sep 25, 2025
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ethtool --show-channel, unfortunately, doesn't support --json, so the output parsing is necessary.

The rest of the logic also seems fine to me.

@natali-rs1985 natali-rs1985 changed the title T7789: T7661: VPP prevent failing to set XDP driver in clouds T7789: T7661: VPP prevent failing to load XDP in clouds (ena/dve drivers) Sep 29, 2025
@natali-rs1985 natali-rs1985 changed the title T7789: T7661: VPP prevent failing to load XDP in clouds (ena/dve drivers) T7789: T7661: VPP prevent failing to load XDP in clouds (ena/gve drivers) Sep 29, 2025
Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests VPP 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • Config tests VPP 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

if rx_queues > max_rx_queues:
raise ConfigError(
f'Maximum supported number of RX queues for interface {iface} is {max_rx_queues}. '
f'Please set "xdp-options num-rx-queues" to {max_rx_queues} or fewer'
Copy link
Member

@sever-sever sever-sever Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It allows to set all, but doesn't allow to set 7 after this

vyos@r14# sudo ethtool -l eth1
Channel parameters for eth1:
Pre-set maximums:
RX:		n/a
TX:		n/a
Other:		n/a
Combined:	8
Current hardware settings:
RX:		n/a
TX:		n/a
Other:		n/a
Combined:	4
[edit]
vyos@r14# 
[edit]
vyos@r14# set vpp settings interface eth1 driver xdp 
[edit]
vyos@r14# set vpp settings interface eth1 xdp-options num-rx-queues all
[edit]
vyos@r14# commit
[edit]
vyos@r14# 
[edit]
vyos@r14# set vpp settings interface eth1 xdp-options num-rx-queues 8
[edit]
vyos@r14# commit
[ vpp ]
Maximum supported number of RX queues for interface eth1 is 4. Please
set "xdp-options num-rx-queues" to 4 or fewer
[[vpp]] failed
Commit failed
[edit]
vyos@r14# sudo ethtool -l defunct_eth1
Channel parameters for defunct_eth1:
Pre-set maximums:
RX:		n/a
TX:		n/a
Other:		n/a
Combined:	8
Current hardware settings:
RX:		n/a
TX:		n/a
Other:		n/a
Combined:	8
[edit]
vyos@r14# 


vyos@r14# set vpp settings interface eth1 xdp-options num-rx-queues 7
[edit]
vyos@r14# commit
[ vpp ]
Maximum supported number of RX queues for interface eth1 is 4. Please
set "xdp-options num-rx-queues" to 4 or fewer
[[vpp]] failed
Commit failed
[edit]
vyos@r14# 

If we try to set 2, afoter those steps:

vyos@r14# set vpp settings interface eth1 xdp-options num-rx-queues 2
[edit]
vyos@r14# commit
[ vpp ]

WARNING: Not all RX queues will be connected to VPP for eth1!


[edit]
vyos@r14# sudo ethtool -l defunct_eth1
Channel parameters for defunct_eth1:
Pre-set maximums:
RX:		n/a
TX:		n/a
Other:		n/a
Combined:	8
Current hardware settings:
RX:		n/a
TX:		n/a
Other:		n/a
Combined:	8
[edit]
vyos@r14# 

Copy link

github-actions bot commented Oct 2, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@natali-rs1985 natali-rs1985 marked this pull request as draft October 8, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bp/circinus Create automatic backport for circinus conflicts current
Development

Successfully merging this pull request may close these issues.

3 participants