syslog: T6858: bugfix remote syslog using TCP

[c-po]

Change Summary

Commit 042be39 (syslog: T5367: add format option to include timezone in message) added an invalid, outer if-statement when rendering the rsyslog configuration option for TCP.

Remote hosts only got added when the format option "octet-counting" was defined in addition to the TCP protocol. This has been fix and now TCP transport is decoupled from octet-counting mode.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

• https://vyos.dev/T6858

Related PR(s)

• syslog: T5367: add format option to include timezone in message #4061

How to test

set system syslog host 10.5.0.20 facility all level 'all'
set system syslog host 10.5.0.20 port '10513'
set system syslog host 10.5.0.20 protocol 'tcp'

Smoketest result

vyos@vyos:~$ /usr/libexec/vyos/tests/smoke/cli/test_system_syslog.py
test_syslog_basic (__main__.TestRSYSLOGService.test_syslog_basic) ... ok
test_syslog_global (__main__.TestRSYSLOGService.test_syslog_global) ... ok
test_syslog_remote (__main__.TestRSYSLOGService.test_syslog_remote) ... ok

----------------------------------------------------------------------
Ran 3 tests in 13.652s

OK

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[github-actions]

👍
No issues in PR Title / Commit Title

[github-actions]

❌ Issues found in unused-imports check. . Please refer the workflow run

[github-actions]

CI integration ❌ failed!

Details

CI logs

• CLI Smoketests (no interfaces) ❌ failed
• CLI Smoketests (interfaces only) 👍 passed
• Config tests 👍 passed
• RAID1 tests 👍 passed
• TPM tests 👍 passed