migration: T6006: add system component version to config.boot.default by separating activation from migration #3587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
NOTE: required companion PR's:
vyos-build: vyos/vyos-build#651
vyatta-op: vyos/vyatta-op#91
Distinguish
activation-scripts
frommigration-scripts
, to avoid migration ofconfig.boot.default
on installation and its attendant problems. The organization here may be subsumed into other ongoing development, but the explicit distinction is recommended to resolve open issues and delimit the issue.The original problem: config settings were either introduced when undesirable, or missed when applicable, dependent on the effects of specific migration scripts. For example:
migration-scripts/conntrack/2-to-3
: adds back in conntrack modules after droppingdisable
boolean valuemigration-scripts/interfaces/20-to-21
: detects and adds offload settings, when supported by the systemThe former may not be desired, but will automatically be added if
config.boot.default
has component versionconntrack
< 3; the latter is desired, but unavailable if component versioninterfaces
> 20.Making the distinction activate/migrate and installing current system versions to config.boot.default resolves these issues, and provides a model going forward.
Types of changes
Related Task(s)
Related PR(s)
vyos/vyos-build#651
vyos/vyatta-op#91
Component(s) name
Proposed changes
How to test
Smoketest result
Checklist: