Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration: T6006: add system component version to config.boot.default by separating activation from migration #3587

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Jun 6, 2024

Change Summary

NOTE: required companion PR's:
vyos-build: vyos/vyos-build#651
vyatta-op: vyos/vyatta-op#91

Distinguish activation-scripts from migration-scripts, to avoid migration of config.boot.default on installation and its attendant problems. The organization here may be subsumed into other ongoing development, but the explicit distinction is recommended to resolve open issues and delimit the issue.

The original problem: config settings were either introduced when undesirable, or missed when applicable, dependent on the effects of specific migration scripts. For example:

migration-scripts/conntrack/2-to-3: adds back in conntrack modules after dropping disable boolean value
migration-scripts/interfaces/20-to-21: detects and adds offload settings, when supported by the system

The former may not be desired, but will automatically be added if config.boot.default has component version conntrack < 3; the latter is desired, but unavailable if component version interfaces > 20.

Making the distinction activate/migrate and installing current system versions to config.boot.default resolves these issues, and provides a model going forward.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

vyos/vyos-build#651
vyos/vyatta-op#91

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Jun 6, 2024
@jestabro jestabro marked this pull request as ready for review June 6, 2024 01:48
@jestabro jestabro requested a review from a team as a code owner June 6, 2024 01:48
@dmbaturin dmbaturin merged commit f6752de into vyos:current Jun 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants