Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op mode: T4519: Show DUID instead of IAID_DUID #3462

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

nvollmar
Copy link
Contributor

@nvollmar nvollmar commented May 16, 2024

Change Summary

Replace IAID_DUID with DUID in op command show dhcpv6 server lease like current does.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): change to command output

Related Task(s)

https://vyos.dev/T4519

Component(s) name

dhcp

Proposed changes

List DUID instead of IAID_DUID in leases overview to make adding static mappings easier.

How to test

Aquire a DHCPv6 lease and list the current leases with show dhcpv6 server lease.
Last column should be the DUID instead of IAID_DUID

Smoketest result

Couldn't really test it as I can't custom build Sagitta anymore

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label May 16, 2024
@nvollmar nvollmar changed the title Show DUID instead of IAID_DUID op mode: T4519 Show DUID instead of IAID_DUID May 16, 2024
@nvollmar nvollmar changed the title op mode: T4519 Show DUID instead of IAID_DUID op mode: T4519: Show DUID instead of IAID_DUID May 16, 2024
@c-po c-po merged commit 899ed3c into vyos:sagitta May 16, 2024
4 of 5 checks passed
@nvollmar nvollmar deleted the T4519 branch September 11, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sagitta VyOS 1.4 LTS
Development

Successfully merging this pull request may close these issues.

3 participants