Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6335: Add/Update EVPN op commands #3458

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

l0crian1
Copy link
Contributor

Change Summary

Added the following commands:
show evpn
show evpn es
show evpn es
show evpn es detail
show evpn es-evi
show evpn es-evi detail
show evpn es-evi vni
show evpn vni
show evpn vni detail
show evpn vni

Updated the following commands:
show evpn access-vlan
show evpn arp-cache
show evpn mac
show evpn next-hops
show evpn rmac

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T6335

Related PR(s)

Component(s) name

evpn, op-mode

Proposed changes

Additional EVPN op commands that are available in FRR have been exposed to VyOS. Additionally some existing commands were updated with exposure to the API as well as completion helpers.

How to test

Configure EVPN and run show commands:
Examples:

vyos@vyos:~$ show evpn es
Type: B bypass, L local, R remote, N non-DF
ESI                            Type ES-IF                 VTEPs
03:aa:bb:cc:dd:ee:f0:00:00:64  LN   bond0
03:aa:bb:cc:dd:ee:f2:00:00:65  LN   bond1
vyos@vyos:~$ show evpn vni
VNI        Type VxLAN IF              # MACs   # ARPs   # Remote VTEPs  Tenant VRF
102        L2   vxlan2                0        0        0               default
100        L2   vxlan0                0        0        0               default
105        L2   vxlan5                0        0        0               default
103        L2   vxlan3                0        0        0               default
109        L2   vxlan9                0        0        0               default
110        L2   vxlan10               0        0        0               default
108        L2   vxlan8                0        0        0               default
101        L2   vxlan1                0        0        0               default
107        L2   vxlan7                0        0        0               default
106        L2   vxlan6                0        0        0               default
104        L2   vxlan4                0        0        0               default
vyos@vyos:~$ show evpn vni 100
VNI: 100
 Type: L2
 Vlan: 1
 Bridge: br0
 Tenant VRF: default
 VxLAN interface: vxlan0
 VxLAN ifIndex: 19
 SVI interface: br0
 SVI ifIndex: 6
 Local VTEP IP: 10.1.2.2
 Mcast group: 0.0.0.0
 No remote VTEPs known for this VNI
 Number of MACs (local and remote) known for this VNI: 0
 Number of ARPs (IPv4 and IPv6, local and remote) known for this VNI: 0
 Advertise-gw-macip: No
 Advertise-svi-macip: No

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Added the following commands:
show evpn
show evpn es
show evpn es <es-id>
show evpn es detail
show evpn es-evi
show evpn es-evi detail
show evpn es-evi vni <num>
show evpn vni
show evpn vni detail
show evpn vni <num>

Updated the following commands:
show evpn access-vlan
show evpn arp-cache
show evpn mac
show evpn next-hops
show evpn rmac
Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python completion helpers tend to be super slow as the interpreter needs to be started up. It would be better to have the completion helpers available in bash.

Converted completion helpers from python to bash for performance

Previous commit:
Added the following commands:
show evpn
show evpn es
show evpn es <es-id>
show evpn es detail
show evpn es-evi
show evpn es-evi detail
show evpn es-evi vni <num>
show evpn vni
show evpn vni detail
show evpn vni <num>

Updated the following commands:
show evpn access-vlan
show evpn arp-cache
show evpn mac
show evpn next-hops
show evpn rmac
@l0crian1
Copy link
Contributor Author

Python completion helpers tend to be super slow as the interpreter needs to be started up. It would be better to have the completion helpers available in bash.

Thanks, I was actually wondering why tab completion on partials felt a little sluggish. Done!

@l0crian1 l0crian1 requested a review from c-po May 16, 2024 12:17
@c-po c-po requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and sever-sever and removed request for a team May 16, 2024 18:13
@c-po
Copy link
Member

c-po commented May 16, 2024

@Mergifyio backport sagitta

Copy link
Contributor

mergify bot commented May 16, 2024

backport sagitta

✅ Backports have been created

@c-po c-po merged commit 3606418 into vyos:current May 16, 2024
7 of 8 checks passed
c-po added a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants