Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency cookie to v0.7.0 [security] #856

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 8, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
cookie 0.6.0 -> 0.7.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-47764

Impact

The cookie name could be used to set other fields of the cookie, resulting in an unexpected cookie value. For example, serialize("userName=<script>alert('XSS3')</script>; Max-Age=2592000; a", value) would result in "userName=<script>alert('XSS3')</script>; Max-Age=2592000; a=test", setting userName cookie to <script> and ignoring value.

A similar escape can be used for path and domain, which could be abused to alter other fields of the cookie.

Patches

Upgrade to 0.7.0, which updates the validation for name, path, and domain.

Workarounds

Avoid passing untrusted or arbitrary values for these fields, ensure they are set by the application instead of user input.

References


Release Notes

jshttp/cookie (cookie)

v0.7.0: 0.7.0

Compare Source


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
iron-session ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 3:39am

@CesarIb
Copy link

CesarIb commented Oct 16, 2024

Hi, is possible to merge this?, Im using iron-session as dependency but Im getting security alerts for vulnerability in the current version of cookie

@sam-hq
Copy link

sam-hq commented Nov 5, 2024

@vvo Seems like a non-breaking security patch. Is this something that can get merged? Tagging you for visibility.

@vvo vvo merged commit c32d1e0 into main Nov 12, 2024
3 checks passed
@vvo vvo deleted the renovate/npm-cookie-vulnerability branch November 12, 2024 08:34
@sam-hq
Copy link

sam-hq commented Nov 12, 2024

Thank you 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants