Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated http-message requirement #16

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Updated http-message requirement #16

merged 2 commits into from
Feb 13, 2024

Conversation

mikebarlow
Copy link
Contributor

Description

This PR updates the requirement for psr/http-message to version 2.

Version 2 of psr/http-message was released April 2023, so it has been available for just short of a year. The release simply adds return type-hints to the interfaces and has no impact on the running of vultr-php sdk.

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@optik-aper
Copy link
Member

@mikebarlow thanks for taking a look at this! I'll see if I can figure out what to do about the tests going forward. But I think this is probably a good thing to merge. Also, would be smart for us to get dependabot working in this repo, so, I'll set that up and get a new release after updating dependencies and testing.

@optik-aper optik-aper self-requested a review February 13, 2024 23:47
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging to move forward on getting deps updated

@optik-aper optik-aper merged commit 54cf565 into vultr:main Feb 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants