Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix xfs mount issues #212

Merged
merged 3 commits into from
May 13, 2024
Merged

fix xfs mount issues #212

merged 3 commits into from
May 13, 2024

Conversation

happytreees
Copy link
Contributor

Description

This resolves issues we are seeing when mounting XFS filesystems

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@happytreees happytreees added the enhancement New feature or request label May 13, 2024
@happytreees happytreees self-assigned this May 13, 2024
@github-actions GitHub Actions
Copy link

Unit Tests and Coverage

Show Output 
?   	github.com/vultr/vultr-csi/cmd/csi-vultr-driver	[no test files]%0A=== RUN   TestCreateVolume%0Atime="2024-05-13T18:15:11Z" level=info msg="Create Volume: called" capabilities="[mount:<> access_mode:<mode:SINGLE_NODE_WRITER > ]" test="create volume" volume-name=volume-test-name%0Atime="2024-05-13T18:15:12Z" level=info msg="Create Volume: created volume" size=10737418240 test="create volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec volume-name=test-bs volume-size=10%0A--- PASS: TestCreateVolume (1.00s)%0A=== RUN   TestDeleteVolume%0Atime="2024-05-13T18:15:12Z" level=info msg="Delete volume: called" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec%0Atime="2024-05-13T18:15:12Z" level=info msg="Delete Volume: deleted" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec%0A--- PASS: TestDeleteVolume (0.00s)%0A=== RUN   TestPublishVolume%0A--- PASS: TestPublishVolume (0.00s)%0A=== RUN   TestUnPublishVolume%0Atime="2024-05-13T18:15:12Z" level=info msg="Controller Publish Unpublish: called" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088%0Atime="2024-05-13T18:15:12Z" level=info msg="Controller Unublish Volume: unpublished" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088%0A--- PASS: TestUnPublishVolume (0.00s)%0A=== RUN   TestDriverSuite%0A--- PASS: TestDriverSuite (0.00s)%0APASS%0Atime="2024-05-13T18:15:12Z" level=info msg="Start listening with scheme unix, addr /tmp/csi.sock"%0Atime="2024-05-13T18:15:12Z" level=info msg="Listening for connections on address: &net.UnixAddr{Name:"/tmp/csi.sock", Net:"unix"}" address=/tmp/csi.sock proto=unix%0A	github.com/vultr/vultr-csi/driver	coverage: 22.2%25 of statements%0Aok  	github.com/vultr/vultr-csi/driver	1.007s	coverage: 22.2%25 of statements

Pusher: @happytreees, Action: pull_request_target

@github-actions GitHub Actions
Copy link

Unit Tests and Coverage

Show Output 
?   	github.com/vultr/vultr-csi/cmd/csi-vultr-driver	[no test files]%0A=== RUN   TestCreateVolume%0Atime="2024-05-13T18:18:54Z" level=info msg="Create Volume: called" capabilities="[mount:<> access_mode:<mode:SINGLE_NODE_WRITER > ]" test="create volume" volume-name=volume-test-name%0Atime="2024-05-13T18:18:55Z" level=info msg="Create Volume: created volume" size=10737418240 test="create volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec volume-name=test-bs volume-size=10%0A--- PASS: TestCreateVolume (1.00s)%0A=== RUN   TestDeleteVolume%0Atime="2024-05-13T18:18:55Z" level=info msg="Delete volume: called" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec%0Atime="2024-05-13T18:18:55Z" level=info msg="Delete Volume: deleted" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec%0A--- PASS: TestDeleteVolume (0.00s)%0A=== RUN   TestPublishVolume%0A--- PASS: TestPublishVolume (0.00s)%0A=== RUN   TestUnPublishVolume%0Atime="2024-05-13T18:18:55Z" level=info msg="Controller Publish Unpublish: called" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088%0Atime="2024-05-13T18:18:55Z" level=info msg="Controller Unublish Volume: unpublished" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088%0A--- PASS: TestUnPublishVolume (0.00s)%0A=== RUN   TestDriverSuite%0A--- PASS: TestDriverSuite (0.00s)%0APASS%0Atime="2024-05-13T18:18:55Z" level=info msg="Start listening with scheme unix, addr /tmp/csi.sock"%0Atime="2024-05-13T18:18:55Z" level=info msg="Listening for connections on address: &net.UnixAddr{Name:"/tmp/csi.sock", Net:"unix"}" address=/tmp/csi.sock proto=unix%0A	github.com/vultr/vultr-csi/driver	coverage: 21.1%25 of statements%0Aok  	github.com/vultr/vultr-csi/driver	1.007s	coverage: 21.1%25 of statements

Pusher: @happytreees, Action: pull_request_target

@github-actions GitHub Actions
Copy link

Unit Tests and Coverage

Show Output 
?   	github.com/vultr/vultr-csi/cmd/csi-vultr-driver	[no test files]%0A=== RUN   TestCreateVolume%0Atime="2024-05-13T18:22:13Z" level=info msg="Create Volume: called" capabilities="[mount:<> access_mode:<mode:SINGLE_NODE_WRITER > ]" test="create volume" volume-name=volume-test-name%0Atime="2024-05-13T18:22:14Z" level=info msg="Create Volume: created volume" size=10737418240 test="create volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec volume-name=test-bs volume-size=10%0A--- PASS: TestCreateVolume (1.00s)%0A=== RUN   TestDeleteVolume%0Atime="2024-05-13T18:22:14Z" level=info msg="Delete volume: called" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec%0Atime="2024-05-13T18:22:14Z" level=info msg="Delete Volume: deleted" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec%0A--- PASS: TestDeleteVolume (0.00s)%0A=== RUN   TestPublishVolume%0A--- PASS: TestPublishVolume (0.00s)%0A=== RUN   TestUnPublishVolume%0Atime="2024-05-13T18:22:14Z" level=info msg="Controller Publish Unpublish: called" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088%0Atime="2024-05-13T18:22:14Z" level=info msg="Controller Unublish Volume: unpublished" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088%0A--- PASS: TestUnPublishVolume (0.00s)%0A=== RUN   TestDriverSuite%0A--- PASS: TestDriverSuite (0.00s)%0APASS%0Atime="2024-05-13T18:22:14Z" level=info msg="Start listening with scheme unix, addr /tmp/csi.sock"%0Atime="2024-05-13T18:22:14Z" level=info msg="Listening for connections on address: &net.UnixAddr{Name:"/tmp/csi.sock", Net:"unix"}" address=/tmp/csi.sock proto=unix%0A	github.com/vultr/vultr-csi/driver	coverage: 22.9%25 of statements%0Aok  	github.com/vultr/vultr-csi/driver	1.007s	coverage: 22.9%25 of statements

Pusher: @happytreees, Action: pull_request_target

optik-aper
optik-aper approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@optik-aper optik-aper added the bug Something isn't working label May 13, 2024
@optik-aper optik-aper merged commit 1183bcd into master May 13, 2024
6 of 7 checks passed
@optik-aper optik-aper deleted the xfs-fix branch May 13, 2024 18:25
@optik-aper optik-aper mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@optik-aper optik-aper optik-aper approved these changes

Assignees

@happytreees happytreees

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@happytreees @optik-aper