Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mdisk_mode flag for baremetal create #449

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

fjoenichols
Copy link
Contributor

Description

This change enables mdisk_mode as a flag for create baremetal.

The api was recently updated to include mdisk_mode for baremetal servers. This allows specifying raid configuration for baremetal servers being provisioned.

Copy link

Unit Tests and Coverage

Show Output
?   	github.com/vultr/vultr-cli/v3	[no test files]

Pusher: @fjoenichols, Action: pull_request_target

@optik-aper optik-aper self-requested a review May 30, 2024 13:57
@optik-aper optik-aper added the enhancement New feature or request label May 30, 2024
optik-aper
optik-aper previously approved these changes Jun 3, 2024
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working

@optik-aper
Copy link
Member

@optik-aper optik-aper self-requested a review June 3, 2024 22:42
Copy link

github-actions bot commented Jun 9, 2024

Unit Tests and Coverage

Show Output
?   	github.com/vultr/vultr-cli/v3	[no test files]

Pusher: @fjoenichols, Action: pull_request_target

@fjoenichols
Copy link
Contributor Author

@fjoenichols Will you fix the lint failures? https://github.com/vultr/vultr-cli/actions/runs/9289966096/job/25745637244?pr=449

It's fixed now. Thanks

Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the long line, this is okay. I'll fix in a separate PR

@optik-aper optik-aper merged commit 91fba88 into vultr:master Jun 11, 2024
3 of 4 checks passed
@optik-aper optik-aper mentioned this pull request Jun 11, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants