Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite backups #157

Closed
wants to merge 2 commits into from
Closed

Conversation

mamclaughlin
Copy link
Contributor

@mamclaughlin mamclaughlin commented May 26, 2021

Description

rewrite of backups resource

Related Issues

Related to #155

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

"context"

"github.com/vultr/vultr-cli/pkg/cli"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goimports this please

}

// Options for backups
type BackupOptions struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this to Options

)

// BackupOptionsInterface ...
type BackupOptionsInterface interface {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this to Interface


cmd := &cobra.Command{
Use: "backup",
Aliases: []string{"backups", "backup", "b"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backup isn't needed here since it's the default use


// Columns ...
func (b *BackupsPrinter) Columns() map[int][]interface{} {
return map[int][]interface{}{0: {"ID", "DATE CREATED", "NAME", "KEY"}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't the right columns?

@happytreees happytreees closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants