Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace NonZeroT with NonZero<T> #2641

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Replace NonZeroT with NonZero<T> #2641

merged 2 commits into from
Feb 7, 2025

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Feb 7, 2025 •
edited
Loading

No description provided.

@marc0246
Copy link
Contributor

marc0246 commented Feb 7, 2025

NonZeroU64 is a type alias for NonZero<u64>, so there is no breaking change due to that. I think we should keep the type aliases like std does to avoid the break.

@marc0246
Copy link
Contributor

marc0246 commented Feb 7, 2025 •
edited
Loading

By that I mean, re-add the type NonZeroDeviceSize = NonZero<DeviceSize> and type NonNullDeviceAddress = NonZero<DeviceAddress> but keep the other changes.

@Rua
Copy link
Contributor Author

Rua commented Feb 7, 2025

Add back only the type aliases, but not the places where they were formerly used?

@marc0246
Copy link
Contributor

marc0246 commented Feb 7, 2025

I think you may have missed my other message but yes.

@marc0246
Copy link
Contributor

marc0246 commented Feb 7, 2025

Awesome, thank

@marc0246 marc0246 merged commit ce3b0d6 into vulkano-rs:master Feb 7, 2025
6 checks passed
@Rua Rua deleted the NonZero branch February 7, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rua @marc0246