Clean up and refactor #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roysc
force-pushed
the
lazy-upstream
branch
2 times, most recently
from
c50a9a6
to
a246524
Compare
This introduces a largely rewritten implementation of the SMT which operates on a cached, lazily-loaded tree structure which must be explicitly committed to DB, replacing the existing pattern of performing DB reads and writes on for each operation. This gives a significant performance improvement on all operations while preserving backwards compatibility of commitment hashes. This also: * refactors the hasher objects to allow tree paths and stored values to be hashed independently, and Options to configure them. By passing an identity function as the path hasher, the raw key can be used directly as the leaf. * removes value storage from the tree; the caller must maintain their own value mapping. * removes the DeepSubtree code supporting state-transition fraud proofs, as it was not compatible as-is with this implementation (but there should be no technical block to adapting it to this pattern). * renames various types and decouples the path and value hashing functions. * expands tests to cover corner cases, e.g. orphan node removal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various renames and refactoring of types, including hashers.