Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VUFIND-1677] Prepare for laminas-view v3 #4213

Open
wants to merge 35 commits into
base: dev
Choose a base branch
from
Open

[VUFIND-1677] Prepare for laminas-view v3 #4213

wants to merge 35 commits into from

Conversation

demiankatz
Copy link
Member

@demiankatz demiankatz commented Jan 28, 2025 •
edited
Loading

Changes coming in laminas-view v3 make it impossible to extend the internals of provided view helpers, so the asset pipeline system needs to be refactored to work differently.

TODO

  • Create assetManager helper as wrapper around head* and foot* helpers
  • Revise inlineScript calls to use assetManager
    • Adjust templates
    • Adjust module code
    • Eliminate custom InlineScript view helper
  • Refactor assetManager internals to support asset combination/minification when configured to do so
    • Refactor CSS processing
    • Refactor JS processing
  • Deduplicate assets when concatenating them in the pipeline
  • Eliminate FootScript helper
  • Upgrade to latest version of laminas-view
  • TEST!
  • Resolve VUFIND-1677 when merging
  • Update changelog when merging (always use assetManager; note removal of internal helpers)

@demiankatz demiankatz added the architecture pull requests that involve significant refactoring / architectural changes label Jan 28, 2025
@demiankatz demiankatz added this to the 11.0 milestone Jan 28, 2025
@demiankatz demiankatz marked this pull request as draft January 28, 2025 20:51
@demiankatz demiankatz marked this pull request as ready for review February 5, 2025 12:24
@demiankatz demiankatz requested a review from EreMaijala February 5, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EreMaijala EreMaijala Awaiting requested review from EreMaijala

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
architecture pull requests that involve significant refactoring / architectural changes
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
1 participant
@demiankatz