Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SimilarItemsCarousel tab with Channels tab. #4209

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

demiankatz
Copy link
Member

@demiankatz demiankatz commented Jan 27, 2025

As discussed on #4165, this PR removes the SimilarItemsCarousel tab and replaces it with a default configuration of the Channels tab that offers equivalent functionality. This reduces the number of independent carousel implementations in the code base, simplifying future accessibility/modernization efforts. This remains backward compatible with existing configurations.

TODO

  • Fix bug that sometimes causes garbled display of channels (to reproduce, go to a record URL with Channels tab as part of the URL but including a hash for a different tab, such as http://localhost/vufind/Record/0000183626-0/Channels#usercomments and then click on the Similar Items tab; the result will be formatted like this:
    image)
  • Update changelog when merging (deleted classes/templates)

@demiankatz demiankatz added this to the 11.0 milestone Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant