Advanced search meets CSS grid #4076
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
requested changes
Nov 12, 2024
There was a problem hiding this comment.
@crhallberg, looks like you need to run the update-bootstrap5 phing action to get the themes in sync.
demiankatz
requested changes
Feb 4, 2025
| <h1 class="pull-left flip"><?=$this->transEsc('Advanced Search')?></h1> | ||
| <div id="groupJoin" class="form-inline pull-right flip"> | ||
| <div class="adv-search-header"> | ||
| <h2><?=$this->transEsc('Advanced Search')?></h2> |
There was a problem hiding this comment.
This appears to be undoing #4221, which is probably not the desired outcome.
| @@ -229,7 +237,7 @@ | |||
| </div> | |||
| <?php | |||
| $script = <<<JS | |||
| $('#groupPlaceHolder').click(function(e) { | |||
| $('#adv-add-group-btn').click(function(e) { | |||
There was a problem hiding this comment.
Is it worth de-jQuerying this while we're changing it anyway, since I think it would be a pretty minor change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an upstream fix for a local issue we were having where the search type selects were too narrow to display our longer options. It may be time to refactor how the HTML is built, but I only changed enough to remove extra containers and such.