VUFIND-1667: Fix tabbing within a modal dialog #3642
Conversation
themes/bootstrap3/js/lightbox.js
Outdated
| var focEls = _modal.find(":tabbable"); | ||
| var lastEl = $(focEls[focEls.length-1]); | ||
| $(lastEl).off('keydown.bs.modal'); |
There was a problem hiding this comment.
The ugly variable names are just echoing what's in bootstrap-accessibility, for easier reference.
There was a problem hiding this comment.
Looks like one small thing is needed to make continuous integration happy.
Beyond that, I defer to @crhallberg and @EreMaijala for overall approval of this. (Makes sense to me, but want to be sure we do it in a way that can be most easily removed as part of the bootstrap5 migration).
|
Thanks, @maccabeelevine! I'll now look forward to hearing from @crhallberg and/or @EreMaijala when their time permits. |
themes/bootstrap3/js/lightbox.js
Outdated
| // This is moot once that library (and bootstrap3) are retired. | ||
| var focEls = _modal.find(":tabbable"); | ||
| var lastEl = $(focEls[focEls.length - 1]); | ||
| $(lastEl).off('keydown.bs.modal'); |
There was a problem hiding this comment.
Well sussed! I notice that it applied to the first element as well. Might as well take care of both, right?
https://github.com/paypal/bootstrap-accessibility-plugin/blob/main/src/js/modal.js#L16
There was a problem hiding this comment.
Sure, I made that change, I don't think there is any impact but I agree it's better to remove both listeners since we really want to fully replace the original function.
There was a problem hiding this comment.
Looks fine to me. I'll wait for confirmation from @crhallberg before the final merge.
For https://openlibraryfoundation.atlassian.net/browse/VUFIND-1667
Disable the "Modal Extension" event listener in bootstrap-accessibility(.min).js. Lightbox.js does the same idea better in
retainFocus.