Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useFocusTrap): support multiple refs #4022

Merged
merged 6 commits into from
Jul 17, 2024

Conversation

Sma11X
Copy link
Contributor

@Sma11X Sma11X commented Jun 6, 2024

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

Support multiple refs and string array for useFocusTrap

Additional context

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 6, 2024
@@ -60,7 +61,7 @@ export interface UseFocusTrapReturn {
* @see https://vueuse.org/useFocusTrap
*/
export function useFocusTrap(
target: MaybeElementRef,
target: string | MaybeComputedElementRef | (MaybeComputedElementRef | string)[] | MaybeRefOrGetter<(MaybeComputedElementRef | string)[]>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifying the type to Arrayable<MaybeRefOrGetter<string> | MaybeComputedElementRef> seems more convenient.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t realize there was such a type, thanks for pointing it out.

@antfu antfu added the direction: approved The direction of feature/change is approved by the team. May require some small changes. label Jun 11, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 17, 2024
@antfu antfu added this pull request to the merge queue Jul 17, 2024
Merged via the queue into vueuse:main with commit 83c4181 Jul 17, 2024
7 checks passed
@Sma11X Sma11X deleted the feat/useFocusTrap-multiple-refs branch July 18, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
direction: approved The direction of feature/change is approved by the team. May require some small changes. lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants