Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: motion component not using and merging custom presets #205

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

BobbieGoede
Copy link
Collaborator

๐Ÿ”— Linked issue

โ“ Type of change

  • ๐Ÿ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • โœจ New feature (a non-breaking change that adds functionality)
  • ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

Resolves #201

This changes the Motion components to also use configured custom directives (should we consider renaming this to presets?) and should also allow merging/overriding by passing variant props as you normally do.

Does this make the components feature complete with the directive implementation? If not, let me know what's missing and I'll see to making it work ๐Ÿ˜„

๐Ÿ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede assigned Tahul and unassigned Tahul Jun 22, 2024
@BobbieGoede BobbieGoede requested a review from Tahul June 22, 2024 17:45
@Tahul Tahul merged commit c23efca into vueuse:main Sep 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom directives/presets do not work for Motion components
2 participants