Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent preset variants from being mutated #182

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

BobbieGoede
Copy link
Member

@BobbieGoede BobbieGoede commented Apr 18, 2024

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #74

This changes the way directive presets are handled, the underlying issue is similar to the one solved in #173, the preset variants are passed and reused and mutated down the line which is most noticeable in situations such as #74 (comment).

To prevent this fix from influencing users variants (I suppose there are use cases where mutating a single motion is desired) I tried to only apply this change to directive presets.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede requested a review from Tahul April 18, 2024 11:53
@BobbieGoede BobbieGoede self-assigned this Apr 18, 2024
@BobbieGoede BobbieGoede requested a review from cpreston321 April 19, 2024 07:14
@BobbieGoede BobbieGoede merged commit e8b0b47 into vueuse:main Apr 20, 2024
5 checks passed
@BobbieGoede BobbieGoede deleted the fix/preset-variants-mutated branch April 20, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add delay to presets animation
2 participants