fix: prevent preset variants from being mutated #182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Resolves #74
This changes the way directive presets are handled, the underlying issue is similar to the one solved in #173, the preset variants are passed and reused and mutated down the line which is most noticeable in situations such as #74 (comment).
To prevent this fix from influencing users variants (I suppose there are use cases where mutating a single motion is desired) I tried to only apply this change to directive presets.
📝 Checklist