Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom directives/presets do not work for Motion components #201

Closed
emavitta opened this issue Jun 11, 2024 · 2 comments · Fixed by #205
Closed

Custom directives/presets do not work for Motion components #201

emavitta opened this issue Jun 11, 2024 · 2 comments · Fixed by #205
Labels
bug Something isn't working

Comments

@emavitta
Copy link

I'm trying to understand if i'm doing something wrong, although everything works.

I'm not using the preset prop on the Motion component, instead i'm using the v-motiondirective. This way i can also use custom directive.

Why specify in the docs the use of the preset and not the v-motion directive? Is it wrong to do it? If so how can i add a custom directive?
@BobbieGoede
Copy link
Collaborator

I'm not sure I understand the question, the <Motion> component serves the same purpose as v-motion. Are you using the directive on a Motion component? If so, this is untested and I would suggest using only the component or the directive approach, not both at once, simply cause I don't know if this has any unexpected behavior.

The component usage is still relatively new, you're right that custom presets are currently not working when passed using the preset prop, I will look into fixing this soon!

@emavitta
Copy link
Author

yep, that's right; it works using directives but i may have found some bugs (or my code is just bad, still haven't figured it out).

@BobbieGoede BobbieGoede changed the title Why use preset on Motion component? Custom directives/presets do not work for Motion components Jun 22, 2024
@BobbieGoede BobbieGoede added the bug Something isn't working label Jun 22, 2024
@BobbieGoede BobbieGoede mentioned this issue Jun 22, 2024
Merged
9 tasks
@Tahul Tahul closed this as completed in #205 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: motion component not using and merging custom presets BobbieGoede/motion
2 participants
@BobbieGoede @emavitta