Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VVirtualScroll): add scrollToIndex options and fractional scroll #20407

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

koush
Copy link

@koush koush commented Aug 31, 2024

Description

scrollToIndex does not scroll to fractional values. Fractional values would allow scrolling to a point between two elements.

For example, scrollToIndex(1.5) should scroll halfway between indices 1 and 2.

scrollToIndex also does not support scroll options, which makes it difficult to programmatically use smooth vs instant scrolling.

This change should be backwards compatible with existing consumers of this API:

  • fractional values did not work at all prior to this change, and would fail.
  • the second options argument did not exist.

@koush koush changed the title feat: scrollToIndex scroll options and scrolling to a point between two indices feat(VVirtualScroll): scrollToIndex scroll options and scrolling to a point between two indices Aug 31, 2024
@koush koush changed the title feat(VVirtualScroll): scrollToIndex scroll options and scrolling to a point between two indices feat(VVirtualScroll): scrollToIndex scroll options and fractional scroll Aug 31, 2024
@koush koush changed the title feat(VVirtualScroll): scrollToIndex scroll options and fractional scroll feat(VVirtualScroll): adds scrollToIndex scroll options and fractional scroll Aug 31, 2024
@koush koush changed the title feat(VVirtualScroll): adds scrollToIndex scroll options and fractional scroll feat(VVirtualScroll): add scrollToIndex options and fractional scroll Sep 2, 2024
@KaelWD KaelWD force-pushed the master branch 3 times, most recently from 4c970f9 to 6a3285f Compare September 3, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant