Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: useCms without SwagShopwarePwa plugin #1999

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mkucmus
Copy link
Collaborator

@mkucmus mkucmus commented Jun 2, 2023

Changes

provides a workaround to not use page resolver from SwagShopwarePwa plugin:

  • use /seo-url endpoint to resolve the URL
  • fetch the corresponding entity using dedicated endpoint: product, category, landing-page

Pros

  • page resolver plugin is not required
  • works with latest v6.5

Cons

  • worst performance due two api calls instead of one
  • no breadcrumbs supported
  • CMS elements and blocks aren't adjusted to the changes to work with latest SW 6 - still need some styling (not strictly related to the PR)

TODO:

  • homepage resolving
  • breadcrumbs handling partially - without links ✅
  • code refactor
  • test coverage

Optional solution for better perfromance

Checklist

@vercel
Copy link

vercel bot commented Jun 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
shopware-pwa-docs ⬜️ Ignored (Inspect) Jun 6, 2023 3:05pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant