[WIP] feat(default-theme): Add newsletter subscription #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
patzick
requested changes
Aug 4, 2022
| </p> | ||
| </slot> | ||
| <SwInput | ||
| v-model="user.email" |
There was a problem hiding this comment.
we shouldn't modify the user's email here, for form purposes we can add prefilled ref, for example
const userEmail = ref(user.value?.email);
Comment on lines
+38
to
+39
| import { getApplicationContext } from "@shopware-pwa/composables" | ||
| import { useUser, useNotifications } from "@shopware-pwa/composables" |
There was a problem hiding this comment.
Suggested change
| import { getApplicationContext } from "@shopware-pwa/composables" | |
| import { useUser, useNotifications } from "@shopware-pwa/composables" | |
| import { getApplicationContext, useUser, useNotifications } from "@shopware-pwa/composables" |
|
@mdanilowicz do we have an issue which blocks us here to link between repositories? available maybe here: https://issues.shopware.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on this PR will be continued after backend fixes
Changes
closes #1756
Checklist