-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nuxt): use lodash.template
directly to compile templates
#1525
Conversation
lodash.template
directly to compile templatelodash.template
for compiling template
lodash.template
for compiling templatelodash.template
directly to compile templates
I encountered this issue while installing the Package Versions"@firebase/app-types": "^0.9.2",
"firebase": "^10.12.2",
"firebase-admin": "^12.2.0",
"firebase-functions": "^5.0.1" Environment Details- Operating System: Darwin
- Node Version: v22.2.0
- Nuxt Version: 3.12.2
- CLI Version: 3.12.0
- Nitro Version: 2.9.7
- Package Manager: [email protected]
- Builder: -
- User Config: future, modules, extends, components, vuefire
- Runtime Modules: [email protected]
- Build Modules: - Temporary WorkaroundTo address the issue temporarily, you can use the following configuration: export default defineNuxtConfig({
future: {
compatibilityVersion: 4,
},
experimental: {
compileTemplate: true,
},
}) Note: This workaround is effective for version 3 only. Version 4 will not be reversible. Additional InformationIt appears that the pending merge of #1545 will resolve this compatibility conflict. |
Thank you Daniel! I should indeed migrate out from templates and split the plugin into multiple ones that are conditionally added by the module. For anybody else wanting to contribute, feel free to open a new PR that split the two plugins with an ejs extension. |
64e1920
to
6e810fb
Compare
Apparently this requires the user to install lodash-es so I think I will release once the plugins are split and no templates are used |
It adds lodash-es to the dependencies. Why would the user need to install it? |
I was as confused as you. Maybe it was because I tried yalc instead of using npm pack. Edit: it works when packing, so I published the new versions |
Whew. Thanks for the heads up about yalc 🙏 |
We are going to be removing support for compiling templates from disk using
lodash.template
in Nuxt v4. This is a PR to move lodash usage directly into vuefire's Nuxt module.It would also be possible to avoid using it entirely, which I would strongly recommend, either:
lodash.template
usage nuxt-modules/color-mode#240getContents