-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use the specified port and not a ramdom port in range[port,highest port] #4451
Conversation
Co-Authored-By: Minami <[email protected]>
I think it is an issue with portfinder and should be fixed there. This PR has problem - if selected port is busy, dev build would throw an error instead of selecting new port. |
hi @AndreasCag There is an issue about the recent behaviour change in 1.0.22 Sure you are right if the port is used, serve will fails. But as option Best Regards, |
@AndreasCag The issue is not really in |
There is a fix for this out for review in portfinder: |
But it actually does specify that it will do that:
|
@therealshark Oops, I missed that. Thanks for pointing it out. |
Closing this now that portfinder has fixed their bug. |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
This PR allow to fix the port running "vue serve" related in https://stackoverflow.com/questions/57536785/vue-npm-run-serve-starts-on-random-port
portfinder give a ramdom port in the range [basePort,highestPort], so asking for port 8080 result to a random port between [8080 and 40000]