-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to generate a Flat Config #25
base: main
Are you sure you want to change the base?
Conversation
1a9f098
to
4edf18c
Compare
4edf18c
to
af60961
Compare
This should now be ready for review! As for now, I'll go and test the various configs in |
Back with some results. In general, the common configs seem to work. The only parsing error I encountered was with scenario 8, which I haven't looked into. You can view the results in this Gist: https://gist.github.com/JoostKersjes/0e6495987a74df8ebf4527f35d924e27 |
Just out of curiosity, why give the option of using the deprecated |
Made me think for a bit, thanks. I didn't want to be too disruptive with this MR so it could be more easily reviewed, so I didn't want to remove the old code. From my perspective, the adoption of flat configs has been slower than I expected. Most of the packages aren't compatible and only have instructions for using an Using packages wrapped in PS: It seems that only a small group of people would run |
vuejs/create-vue#451
Things I have yet to do:
bin/create-eslint-config.js
changeseslint:recommended
oreslint:all
FlatCompat
from default + JS + no PrettiercreateAliasSetting
@eslint/js
&@eslint/eslintrc
when actually neededSome questions:
--ext
CLI flag gone, where should the file path match patterns come from? I thinkcreate-vue
can set them, but what about the manual create use case? Should both get the same defaultfiles: []
?--ignorePath
CLI flag is gone, should ignore patterns now also be part of this project? If so, should that be in this PR?