Skip to content

feat(reactivity): collection iteration should inherit iterator instance methods #12644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

close #12615

Copy link

github-actions bot commented Jan 3, 2025

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+20 B) 37.9 kB (+5 B) 34.2 kB (+15 B)
vue.global.prod.js 158 kB (+20 B) 57.8 kB (+7 B) 51.5 kB (+65 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.3 kB (+20 B) 18.2 kB (+8 B) 16.6 kB (+16 B)
createApp 54.3 kB (+20 B) 21.1 kB (+7 B) 19.3 kB (+3 B)
createSSRApp 58.4 kB (+20 B) 22.9 kB (+7 B) 20.8 kB (+6 B)
defineCustomElement 59.1 kB (+20 B) 22.7 kB (+7 B) 20.7 kB (+1 B)
overall 68.3 kB (+20 B) 26.3 kB (+10 B) 23.9 kB (+8 B)

Copy link

pkg-pr-new bot commented Jan 3, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12644

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12644

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12644

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12644

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12644

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12644

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12644

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12644

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12644

vue

npm i https://pkg.pr.new/vue@12644

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12644

commit: 9f08043

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: reactivity 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Jan 3, 2025
Comment on lines +72 to +75
// iterable protocol
[Symbol.iterator]() {
return this
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this part be removed? I think the inherited method will already return the appropriate this value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: reactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A reactive variable create from the Map data while lost some new functions after use iterator methods like values
2 participants