-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lint): add type-aware rules #12497
Open
johnsoncodehk
wants to merge
30
commits into
vuejs:minor
Choose a base branch
from
johnsoncodehk:tsslint
base: minor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-sfc
@vue/compiler-dom
@vue/compiler-ssr
@vue/runtime-core
@vue/runtime-dom
@vue/reactivity
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
johnsoncodehk
changed the title
test(lint): use tsslint
feat(lint): add type-aware rules
Dec 4, 2024
edison1105
added
ready to merge
The PR is ready to be merged.
🧹 p1-chore
Priority 1: this doesn't change code behavior.
labels
Dec 5, 2024
❌ Deploy Preview for vue-sfc-playground failed. Why did it fail? →
|
Smrtnyk
reviewed
Dec 15, 2024
@@ -159,7 +158,7 @@ export const transformFor: NodeTransform = createStructuralDirectiveTransform( | |||
: isTemplate && | |||
node.children.length === 1 && | |||
isSlotOutlet(node.children[0]) | |||
? (node.children[0] as SlotOutletNode) // api-extractor somehow fails to infer this | |||
? node.children[0] // api-extractor somehow fails to infer this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this comment referring to the now removed assertion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🧹 p1-chore
Priority 1: this doesn't change code behavior.
ready to merge
The PR is ready to be merged.
version: minor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exploration move to tsslint to use type-aware rules in a high-performance manner.
I tested all type-aware rules of
typescript-eslint
and added the ones with no friction from Vue core: