add exportPDF to exported functions #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened #428 to discuss automated check failure due to R dependency issue for older versions. Considering this PR's changes are unrelated to the dependency, I propose Ignore this failure |
|
[ FAIL 0 | WARN 0 | SKIP 13 | PASS 2064 ] |
jubilee2
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
The test has passed, and the code change is simple, just exposing the exportPDF function to let end users see and use it. @nutterb discussed this in another issue, and the export function works for that end user. Since it's officially exported and should not cause any crashes, I approve this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the export tag to
exportPdfdocumentation.I haven't taken the time to run the test suite, as there is no change to the functional code. (It seemed pretty safe, but you can tell me if I'm being too lazy here)