Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment steps #1217

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Add deployment steps #1217

merged 4 commits into from
Mar 28, 2024

Conversation

silvadenisaraujo
Copy link
Contributor

What is the purpose of this pull request?

Improve deployment documentation to ensure we're following the correct steps.

What problem is this solving?

Enables developers to clearly understand the process and run it without issues.

How should this be manually tested?

N/A

Screenshots or example usage

N/A

Types of changes

  • Refactor (non-breaking change that only makes the code better)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Chores checklist

  • Update CHANGELOG.md

@silvadenisaraujo silvadenisaraujo self-assigned this Mar 25, 2024
@silvadenisaraujo silvadenisaraujo marked this pull request as ready for review March 25, 2024 17:24
@filafb
Copy link
Contributor

filafb commented Mar 26, 2024

There is already a documentation for the deployment here https://github.com/vtex/toolbelt/blob/main/docs/maintaining.md. Not sure it's updated though, but it's better to keep it only in one place.

@silvadenisaraujo silvadenisaraujo merged commit 8354db7 into main Mar 28, 2024
4 checks passed
@silvadenisaraujo silvadenisaraujo deleted the chore/update-deployment-docs branch March 28, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants