feat: search product item control #2543
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramondorosario-ct
requested review from
eduardoformiga and
pedromtec
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
…tex/faststore into feat/search-product-item-control
hellofanny
added
enhancement
|
question: Should the product item be clickable in the list? (keeping the previous behaviour, click and go to the product page) |
hellofanny
reviewed
Nov 20, 2024
packages/components/src/molecules/SearchProducts/SearchProductItemControl.tsx
Outdated
Show resolved
Hide resolved
hellofanny
reviewed
Nov 20, 2024
packages/components/src/molecules/SearchProducts/SearchProductItemControl.tsx
Show resolved
Hide resolved
hellofanny
reviewed
Nov 20, 2024
packages/components/src/molecules/SearchProducts/SearchProductItemControl.tsx
Outdated
Show resolved
Hide resolved
hellofanny
reviewed
Nov 21, 2024
packages/ui/src/components/molecules/SearchProducts/styles.scss
Outdated
Show resolved
Hide resolved
packages/ui/src/components/molecules/SearchProducts/styles.scss
Outdated
Show resolved
Hide resolved
packages/ui/src/components/molecules/SearchProducts/styles.scss
Outdated
Show resolved
Hide resolved
packages/ui/src/components/molecules/SearchProducts/styles.scss
Outdated
Show resolved
Hide resolved
packages/ui/src/components/molecules/SearchProducts/styles.scss
Outdated
Show resolved
Hide resolved
packages/components/src/molecules/SearchProducts/SearchProductItemControl.tsx
Outdated
Show resolved
Hide resolved
| ) { | ||
| const [statusAddToCart, setStatusAddToCart] = | ||
| useState<StatusButtonAddToCartType>('default') | ||
| function stopPropagationClick(e: MouseEvent) { |
There was a problem hiding this comment.
question: Should the product item be clickable in the list? (keeping the previous behaviour, click and go to the product page)
There was a problem hiding this comment.
The previous behavior is being maintained; this method is only being used for cart control. As a result, we have a button inside a link, and when the button is clicked, event propagation occurs (which is why this function was implemented).
packages/components/src/molecules/SearchProducts/SearchProductItemControl.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/molecules/SearchProducts/SearchProductItemControl.tsx
Show resolved
Hide resolved
Co-authored-by: Fanny Chien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR is about the creation of a new component for SearchProduct: SearchProductItemControl. Its goal is to display the QuantitySelector and IconButton, while also fitting into the existing structure of SearchProductItem.
The SearchProductItemControl will be part of the implementation of the new "Quick Order" feature, which aims to allow users to place orders quickly and efficiently.
How it works?
The SearchProductItemControl will be used within the SearchProductItemContent. A validation will check whether the QuickOrder feature is enabled or not. If enabled, the SearchProductItemControl will be rendered, maintaining the previous structure with the addition of the controls:
QuantitySelector,CartButton, and/orSKUMatrix.The SearchProductItemControl will receive several props. Among them is
skuMatrixControl, which will be responsible for rendering theSKUMatrix.Printscreens
ps: the "Select multiple" button is just a regular button used for visualization purposes. Once the SKUMatrix is passed, the SKUMatrix trigger will be displayed.