Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Make updates to the config and setup of the project to make it easier to get started #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

siklodi-mariusz
Copy link

This is still a work in progress. There are still a few things to be done:

  • Add delayed_job service to docker-compose.yml
  • Add container to run tests to docker-compose.yml
  • Update README with docker setup instructions

@@ -0,0 +1,8 @@
#!/bin/bash

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this file do?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the docker command entry point and it's also meant to fix an issue with starting rails applications in a docker container described here:
https://docs.docker.com/compose/rails/#define-the-project

Copy link

@abdul-shajin abdul-shajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to leave a blank line at the end of the files. You have missed some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants