DRAFT: Start adding move semantics support #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to move them cheaply (or at least cheaper than by copying everything). Switch to representing null pimpl_ pointer for representing the "empty" state, as is more compatible with move semantics, but this required adding checks for the pointer being null in a number of places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement move semantics for xml::attributes
This works better if the empty object uses empty (null) impl pointer, but this wasn't the convention used in xmlwrapp, where the pointer was always valid so far, even for the null objects. I'm not completely sure if we really want to change this but OTOH using null pointer for an empty object seems much more natural.
@vslavik What do you think, should I continue with changing the other classes in the same way?