PR for appcat on fix/nextcloud_image_registry #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBigLee
force-pushed
the
appcat/290/fix/nextcloud_image_registry
branch
from
20ea8b8 to
fb6187a
Compare
TheBigLee
force-pushed
the
appcat/290/fix/nextcloud_image_registry
branch
from
fb6187a to
6b3e797
Compare
|
@TheBigLee please fix the golden tests |
TheBigLee
force-pushed
the
appcat/290/fix/nextcloud_image_registry
branch
2 times, most recently
from
b1c7c07 to
8f8e2dc
Compare
Signed-off-by: Nicolas Bigler <[email protected]>
TheBigLee
force-pushed
the
appcat/290/fix/nextcloud_image_registry
branch
from
8f8e2dc to
b7cf832
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the registry is hardcoded to docker.io. However, we want to be able to use a different registry in some cases (eg. to avoid rate-limiting). Using this parameter allows us to change the registry for the nextcloud image to another registry.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog
Link: vshn/appcat#290