Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps and make more robust #13

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Update deps and make more robust #13

merged 1 commit into from
Jul 10, 2024

Conversation

Kidswiss
Copy link
Collaborator

@Kidswiss Kidswiss commented Jul 8, 2024

  • The API Server now requires now configuration at all, it will detect what's available at runtime
  • Dependencies have been updated
  • New OpenAPI code generation is required

Summary

  • Short summary of what's included in the PR
  • Give special note to breaking changes

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@Kidswiss Kidswiss added the enhancement New feature or request label Jul 8, 2024
@Kidswiss Kidswiss force-pushed the fix/apiser-runtime branch from ca85355 to 95c1d92 Compare July 8, 2024 12:48
@Kidswiss Kidswiss requested review from a team, TheBigLee, wejdross and zugao and removed request for a team July 8, 2024 12:56
@Kidswiss Kidswiss force-pushed the fix/apiser-runtime branch 4 times, most recently from 7536f72 to 91103d7 Compare July 9, 2024 09:31
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks but looks good. SO much boilerplate is gone. Especially with GracefulDeleter and GracefulCreater interfaces.

cmd/apiserver.go Show resolved Hide resolved
pkg/apiserver/vshn/mariadb/backup.go Show resolved Hide resolved
* The API Server now requires now configuration at all, it will detect
  what's available at runtime
* Dependencies have been updated
* New OpenAPI code generation is required
@Kidswiss Kidswiss force-pushed the fix/apiser-runtime branch from 91103d7 to c8f1635 Compare July 10, 2024 12:38
@Kidswiss Kidswiss merged commit f8225c7 into master Jul 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants