Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Vault agent in service and config file #61

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

sasudi90
Copy link

@sasudi90 sasudi90 commented Jan 17, 2025

Pull Request (PR) description

Add support for Vault Agent

  • possibility to start Vault in 'agent mode' via the service file
  • configuration options for when Vault is running Vault agent

This Pull Request (PR) fixes the following issues

Issue opened here

@bastelfreak bastelfreak added the enhancement New feature or request label Jan 20, 2025
@bastelfreak
Copy link
Member

bastelfreak commented Jan 20, 2025

Thanks for the PR! Can you take a look at https://github.com/voxpupuli/puppet-vault/blob/master/spec/acceptance/class_spec.rb , where we have our acceptance tests, and add one for the vault agent as well please?

Edit: Ups, just noticed that you did that, great work!

@bastelfreak bastelfreak merged commit 19dc6af into voxpupuli:master Jan 20, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants