-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EL 9 support #403
Add EL 9 support #403
Conversation
Suse support was dropped from metadata.json in voxpupuli#292 commit 77ea67b due to lack of working tests.
This also adjusts hiera.yaml to reduce the amount of data that need to be duplicated. This hiera.yaml is now effectively the same as the hiera.yaml used by default with PDK: https://github.com/puppetlabs/pdk-templates/blob/main/moduleroot_init/hiera.yaml.erb
Would it make sense to change hiera to search the |
Like I mentioned in #401 (review), I think it makes the most sense to eliminate the need to specify Python version in this module. But improving |
That's not possible as the python module specifies "3" as the default, el-8's all ship with python 3.6, but puppetboard required python 3.8 - 3.11. |
Yeah, I didn't look into the implementation details yet, but it doesn't make sense that every module using python should have to define the OS's default python version, right? |
Unfortunately, it does as python code/applications (virtualenv's) have different python interpreter requirements... which is definitely out of the sysadmins control. The underlying problem, as I see it, is that the puppet python module only supports managing a single version of python. So if you must support different versions, you can't do it in a consistent way with puppet. |
I am just saying that the data about which version is the OS default should be centralized, so that other modules can look it up. That doesn't prevent overriding the default. |
Same comment as #388 (comment) |
Acceptance tests are hanging trying to install puppetlabs/puppetdb because we don't have a Forge release that supports stdlib 9. puppetlabs/puppetlabs-puppetdb#381 😡 |
metadata.json
in Drop Python 2, implement Python 3, replace virtualenv with native python 3 implementation, drop EPEL parameter #292 commit 77ea67b due to lack of working tests.metadata.json
: Add EL 9 support