Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python::Version as type for puppetboard::python_version #398

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

nmaludy
Copy link
Member

@nmaludy nmaludy commented Dec 12, 2023

Pull Request (PR) description

In RHEL/Rocky 9 the system version of python (python3 package name) is Python 3.9 version. Trying to use 3.9 for puppetboard::python_version yields an error that it can't find that package. Also available is python 3.11 with a package name of python-3.11. Because of the existing regexes in both this module and the python module, i wasn't able to come up with a value for puppetboard::python_version that would allow me to execute with either of those.

Instead this PR simply utilizes the Python::Version type, because that is what the python module uses as its regex verification. Now, we're consistent with what that module uses since it's the actual version spec that matters since we ultimately pass puppetboard::python_version down into the python module anyways.

@nmaludy nmaludy changed the title Use Python::Version as regex Use Python::Version as type for puppetboard::python_version Dec 12, 2023
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That look reasonable.

REFERENCE.md is outdated

Please update REFERENCE.md with

$ bundle exec rake strings:generate:reference

Add it to the PR and CI should continue.

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure is unrelated. LGTM!

@bastelfreak bastelfreak merged commit c3c7660 into voxpupuli:master Dec 14, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants