Skip to content

Upgrade Jira test version to 9.12.18 #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade Jira test version to 9.12.18 #440

wants to merge 2 commits into from

Conversation

SimonHoenscheid
Copy link
Member

Raise Jira Test Version to 9.12.18

@SimonHoenscheid SimonHoenscheid force-pushed the upgrade_test_version branch 2 times, most recently from 59be56a to 8c47726 Compare February 27, 2025 18:21
@SimonHoenscheid SimonHoenscheid added the enhancement New feature or request label Feb 27, 2025
bastelfreak
bastelfreak reviewed Feb 27, 2025
View reviewed changes
spec/acceptance/default_parameters_spec.rb
class { 'jira':
version => '8.16.0',
version => '9.12.18',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version parameter in init.pp still defaults to 8. Should that be updated as well? Or do we want to keep the old version and test if the module can upgrade jira 8 to 9?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jira 8.x, which has been eol a year now, does not support Java 17.
I guess most module users have moved to 9 by now, so I vote for bumping the default version :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully that will solve the Debian 12/Ubuntu 24.04 issues as well.

h-haaks
h-haaks reviewed Feb 28, 2025
View reviewed changes
spec/acceptance/default_parameters_spec.rb
'RedHat' => 'java-11-openjdk-headless',
'Debian' => 'openjdk-11-jre-headless',
'RedHat' => 'java-17-openjdk-headless',
'Debian' => 'openjdk-17-jdk-headless',
Copy link
Contributor

@h-haaks h-haaks Feb 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module doesn't really support java17 that well ..
https://github.com/voxpupuli/puppet-jira/blob/master/types/jvm_types.pp

puppet-jira/manifests/config.pp

Lines 29 to 33 in 7945c72

if $jira::jvm_type == 'openjdk-11' {
$jvm_gc_args = '-XX:+UseG1GC -XX:+ExplicitGCInvokesConcurrent'
} else {
$jvm_gc_args = '-XX:+ExplicitGCInvokesConcurrent'
}

@kenyon kenyon force-pushed the upgrade_test_version branch from 2a85de4 to 40686bc Compare June 23, 2025 22:42
@kenyon kenyon changed the title Upgrade test version Upgrade Jira test version Jun 23, 2025
@kenyon kenyon changed the title Upgrade Jira test version Upgrade Jira test version to 9.12.18 Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak left review comments

@h-haaks h-haaks h-haaks left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonHoenscheid @bastelfreak @h-haaks