Improve shell hygiene

voxpupuli · Jul 12, 2016 · 70d32ca · 70d32ca
1 parent 2f5ace3
commit 70d32ca
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/README.md b/README.md
@@ -18,7 +18,7 @@ to decrypt:
 
 
 ```
-bin/decrypt_credentials.sh
+./bin/decrypt_credentials.sh
 ```
 
 

diff --git a/bin/encrypt_credentials.sh b/bin/encrypt_credentials.sh
@@ -4,13 +4,11 @@ set -eu
 
 rm puppet_credentials.asc
 
-recipients=""
-for recp in `cat recipients.txt`
-do
-    echo "--recipient ${recp}"
-    recipients="${recipients} --recipient ${recp}"
-    gpg --recv-keys ${recp}
-done
+while read -r recp; do
+  echo "--recipient ${recp}"
+  recipients="${recipients} --recipient ${recp}"
+  gpg --recv-keys "${recp}"
+done < recipients.txt
 
-gpg --sign --encrypt --armor $recipients puppet_credentials
+gpg --sign --encrypt --armor "${recipients}" puppet_credentials
-Original file line number
+Diff line change
@@ Expand Up / @@ -18,7 +18,7 @@ to decrypt: @@
     ```
-    bin/decrypt_credentials.sh
+    ./bin/decrypt_credentials.sh
     ```
@@ Expand Down @@