Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update thor requirement from = 1.3.0 to = 1.3.2 #293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 30, 2024

Updates the requirements on thor to permit the latest version.

Release notes

Sourced from thor's releases.

1.3.2

What's Changed

New Contributors

Full Changelog: rails/thor@v1.3.1...v1.3.2

Commits
  • 33b9682 Fix release script
  • de55517 Prepare for 1.3.2
  • d342a4f Add release workflow
  • f2e243d Merge pull request #878 from takmar/fix/find-class-and-command-name
  • 3821657 Fix find_class_and_command_by_namespace to correctly identify hyphenated and ...
  • 871d132 Add command_exists? method to Thor and Thor::Group classes
  • 8f897d5 Merge pull request #880 from duffuniverse/fix-typos-in-readme
  • 42fb1db Add a missed comma to readme
  • 34f6dbe Fix a few typos in README
  • a43d92f Prepare for 1.3.1
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Aug 30, 2024
@bastelfreak
Copy link
Member

@dependabot rebase

Updates the requirements on [thor](https://github.com/rails/thor) to permit the latest version.
- [Release notes](https://github.com/rails/thor/releases)
- [Commits](rails/thor@v1.3.0...v1.3.2)

---
updated-dependencies:
- dependency-name: thor
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/thor-eq-1.3.2 branch from 60412cb to 7683fed Compare February 26, 2025 09:08
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's still broken and requires more work.

@@ -29,5 +29,5 @@ Gem::Specification.new do |spec|
spec.add_runtime_dependency 'gitlab', '>=4', '<6'
spec.add_runtime_dependency 'octokit', '>=4', '<10'
spec.add_runtime_dependency 'puppet-blacksmith', '>= 3.0', '< 9'
spec.add_runtime_dependency 'thor', '1.3.0'
spec.add_runtime_dependency 'thor', '1.3.2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was pinned in 7fe82ae. If only 1.3.1 was broken then I'd prefer this:

Suggested change
spec.add_runtime_dependency 'thor', '1.3.2'
spec.add_runtime_dependency 'thor', '~> 1.3', '!= 1.3.1'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants